Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3dtiles: glTFにマテリアル (PBR Material, Texture) を付与する #308

Merged
merged 15 commits into from
Feb 21, 2024

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Feb 20, 2024

glTFにマテリアル(PBRの色とテクスチャ)を付与します。課題はたくさん残っていますが、このあたりで一旦マージすべきかと思います。

興味があれば nusamai/src/sink/cesiumtiles/ 以下の変化を見て頂ければよいかと思います。

それ以外の部分の変更は、特に重要な意味はないです。

既知の問題+今後の課題:

Close #291

@ciscorn ciscorn self-assigned this Feb 20, 2024
@ciscorn ciscorn requested a review from a team February 20, 2024 16:13
@ciscorn ciscorn marked this pull request as ready for review February 21, 2024 04:05
Copy link
Collaborator

@nokonoko1203 nokonoko1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

流石に処理内容はちゃんと理解できませんでしたが、一通り確認しました!
LGTM!

@ciscorn ciscorn enabled auto-merge (squash) February 21, 2024 05:09
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Files Patch % Lines
nusamai/src/sink/cesiumtiles/material.rs 80.95% 20 Missing ⚠️
nusamai/src/sink/cesiumtiles/slice.rs 89.65% 6 Missing ⚠️
nusamai/src/sink/cesiumtiles/mod.rs 90.56% 5 Missing ⚠️
nusamai-citygml/src/values.rs 90.62% 3 Missing ⚠️
nusamai-plateau/src/appearance.rs 85.71% 2 Missing ⚠️
nusamai/src/sink/gpkg/attributes.rs 0.00% 1 Missing ⚠️
nusamai/src/sink/mvt/tags.rs 0.00% 1 Missing ⚠️
nusamai/src/transformer/transform/flatten.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
GUI ∅ <ø> (∅)
Backend 88.78% <90.39%> (-0.35%) ⬇️
Libraries 91.47% <90.56%> (+0.17%) ⬆️

📢 Thoughts on this report? Let us know!

@ciscorn ciscorn merged commit f5d7a43 into main Feb 21, 2024
4 checks passed
@ciscorn ciscorn deleted the gltf-materials-init branch February 21, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glTFにマテリアル(PBR、テクスチャ)を割り当てる試験実装
2 participants