[Merged by Bors] - Remove unused deps #2455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Jul 12, 2021
alice-i-cecile
added
C-Code-Quality
mockersf
reviewed
Jul 12, 2021
|
Is there any Github action we can add to make sure we don't have unused dependencies? |
|
|
|
The duplicate dependency skip list needs to be updated it seems. proc-macro-crate is now duplicated. |
|
yup #2456 but dependencies jobs are not checked for a merge so it's not a blocker |
mockersf
approved these changes
Jul 13, 2021
mockersf
added
the
S-Ready-For-Final-Review
cart
added
C-Dependencies
bjorn3
force-pushed
the
remove_unused_deps
branch
from
e6968c5
to
27eb8ba
Compare
|
Rebased to re-trigger CI. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
# Objective Reduce compilation time # Solution Remove unused dependencies. While this PR doesn't remove any crates from `Cargo.lock`, it may unlock more build parallelism.
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
# Objective Reduce compilation time # Solution Remove unused dependencies. While this PR doesn't remove any crates from `Cargo.lock`, it may unlock more build parallelism.
|
Pull request successfully merged into main. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
This was tested using cargo generate-lockfile -Zminimal-versions. The following indirect dependencies also have minimal version dependencies. For at least num, rustc-serialize and rand this is necessary to compile on rustc versions that are not older than 1.0. * num = "0.1.27" * rustc-serialize = "0.3.20" * termcolor = "1.0.4" * libudev-sys = "0.1.1" * rand = "0.3.14" * ab_glyph = "0.2.7 Based on #2455
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
# Objective - Unused dependencies are bad ## Solution - Add check for unused dependencies with https://github.com/est31/cargo-udeps - #2455
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective Reduce compilation time # Solution Remove unused dependencies. While this PR doesn't remove any crates from `Cargo.lock`, it may unlock more build parallelism.
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This was tested using cargo generate-lockfile -Zminimal-versions. The following indirect dependencies also have minimal version dependencies. For at least num, rustc-serialize and rand this is necessary to compile on rustc versions that are not older than 1.0. * num = "0.1.27" * rustc-serialize = "0.3.20" * termcolor = "1.0.4" * libudev-sys = "0.1.1" * rand = "0.3.14" * ab_glyph = "0.2.7 Based on bevyengine#2455
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective - Unused dependencies are bad ## Solution - Add check for unused dependencies with https://github.com/est31/cargo-udeps - bevyengine#2455
dekirisu
pushed a commit
to dekirisu/bevy_gltf_trait
that referenced
this pull request
Jul 7, 2024
This was tested using cargo generate-lockfile -Zminimal-versions. The following indirect dependencies also have minimal version dependencies. For at least num, rustc-serialize and rand this is necessary to compile on rustc versions that are not older than 1.0. * num = "0.1.27" * rustc-serialize = "0.3.20" * termcolor = "1.0.4" * libudev-sys = "0.1.1" * rand = "0.3.14" * ab_glyph = "0.2.7 Based on bevyengine/bevy#2455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Reduce compilation time
Solution
Remove unused dependencies. While this PR doesn't remove any crates from
Cargo.lock, it may unlock more build parallelism.