[Merged by Bors] - add check for unused dependencies #2461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Build-System
alice-i-cecile
approved these changes
Jul 13, 2021
bjorn3
approved these changes
Jul 13, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
NiklasEi
reviewed
Jul 13, 2021
| run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev | ||
|
|
||
| - name: Run cargo udeps | ||
| run: cargo udeps |
There was a problem hiding this comment.
From the last run of this job: To find dependencies that are not used by any target, enable '--all-targets'.
Since Bevy supports quite a few different targets, how about adding --all-targets here?
There was a problem hiding this comment.
Targets here means build targets (tests, examples, ...) not target triples. Using --all-targets would prevent detecting when regular dependencies could be dev-dependencies.
cart
added
C-Dependencies
lafi-99
approved these changes
Jul 14, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
# Objective - Unused dependencies are bad ## Solution - Add check for unused dependencies with https://github.com/est31/cargo-udeps - #2455
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective - Unused dependencies are bad ## Solution - Add check for unused dependencies with https://github.com/est31/cargo-udeps - bevyengine#2455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution