Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Create open API specification for create/update connectors #7

Closed
wants to merge 27 commits into from

Conversation

lcawl
Copy link
Owner

@lcawl lcawl commented Jan 10, 2023

Summary

Relates to elastic#137240

This PR creates the open API specification for:

create connector
update connector

@github-actions
Copy link

Documentation preview:

lukasolson and others added 27 commits January 10, 2023 08:36
## Summary

Fixes elastic#148347.

Flaky test runner build:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1719

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
…efault (elastic#148109)

## Summary

Enable the RBAC feature flag for Endpoint management RBAC by default.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary

elastic#147759


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…#147152)

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
This will be used to tag a version with  an abbreviated commit sha
opposed to the current semver style approach.

e.g. `kibana:8.7.0` -> `kibana:abcdef1`

Defaults will remain semver style - this is in support of a testing
pipeline.

## Testing

```
node scripts/build \
  --docker-images \
  --docker-tag="abcdef1" \
  --skip-docker-ubi \
  --skip-docker-cloud \
  --skip-docker-context
```
should produce an image `docker.elastic.co/kibana/kibana:abcdef1`

```
node scripts/build \
  --docker-images \
  --skip-docker-ubi \
  --skip-docker-cloud \
  --skip-docker-context
```
should produce an image `docker.elastic.co/kibana/kibana:8.7.0-SNAPSHOT`
This PR is a simple update of our versions file after the recent bumps
In order to avoid searching the `api_docs` directory at the root of the
repo in VSCode we have to exclude all api_docs dirs from search, so
instead of putting the source of the code that generates the api_docs in
a similarly named dir this just removes that wrapper.
Update the autocomplete suggestions for the ML APIs in dev console.
…ction (elastic#145637)

## Summary

Closes elastic#143369 (~blocked by
elastic#143376)

This PR updates the Stack Management UI and Observability UI to show
Notify When and Throttle parameters at the **action level** instead of
the **rule level**.

The rule-level Check Every dropdown is moved to the end of the rule,
right above the actions form

The Security Solution UX remains unchanged, as it has a unique way of
displaying action notification frequencies at the rule level. Instead,
the API request has changed so that the selected action frequency will
now be stored in each action's `frequency` param instead of at the rule
level.

In all three UIs, existing rules that have legacy rule-level
`notifyWhen` and `frequency` params will have these parameters
seamlessly migrated to the action level when the user edits a rule.

The Rule Details page is also updated to show Notify frequencies in the
Actions column instead of in the first, rule-level column.

### Rule Details Page update
<img width="781" alt="Screen Shot 2022-11-17 at 4 23 02 PM"
src="https://user-images.githubusercontent.com/1445834/202573067-bc55630d-f767-4a93-8d7c-752748da25c2.png">

### Rule Form update
<img width="605" alt="Screen Shot 2022-11-17 at 4 23 10 PM"
src="https://user-images.githubusercontent.com/1445834/202573057-5d50e573-1453-4b63-8e1e-6505fa0261c6.png">
<img width="605" alt="Screen Shot 2022-12-27 at 1 18 12 PM"
src="https://user-images.githubusercontent.com/1445834/209712784-34c2384b-bcc8-4db9-a42d-052d81099a40.png">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
## Summary

This fixes the look of the configured sources cards, which was broken by
an unrelated EUI change.

Before fix:

![image](https://user-images.githubusercontent.com/94373878/211583041-a4dcf94d-c67a-4556-a038-ca223e4111c8.png)

After fix:
<img width="1005" alt="Screenshot 2023-01-10 at 15 47 33"
src="https://user-images.githubusercontent.com/94373878/211583089-ab8cf11e-932d-475f-a928-17b44ca0b0aa.png">

Originally in 8.6:
<img width="1277" alt="Screenshot 2023-01-10 at 15 47 19"
src="https://user-images.githubusercontent.com/94373878/211583158-2236f72d-1ab4-4415-a7ea-e21bc1e274e7.png">
…d API call (elastic#148495)

## Summary
### Engine list UI page

1. Replaced mocked values with Kibana API call in Fetch engines and added test cases
2. Replaced with the types from the `common ` directory suggestion based
on [PR
comment](elastic#147399 (comment))
3. Removed documents column from UI


<img width="1675" alt="Screen Shot 2023-01-05 at 8 07 15 PM"
src="https://user-images.githubusercontent.com/55930906/210909095-3697fb62-758d-4dd1-89c1-2487f3b08db1.png">




### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fix tracking of refresh interval setting in dashboard state
unskip show underlying data tests
…ic#147270)

Fixes elastic#147147

Replaces elastic#147151. Thanks for the
tip @Dosant

PR passes theme$ to toMountPoint

<img width="400" alt="Screen Shot 2022-12-06 at 4 54 49 PM"
src="https://user-images.githubusercontent.com/373691/206051509-207c39f6-125d-46f9-baab-87a5a96a6541.png">

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Resolves elastic#147113
Fixes elastic#134924
Fixes elastic#144445
On week for refactoring the rules list, some of the major things
tackled:

- Remove as much of the `useEffects` as we can. `useEffects` makes it
difficult to track re-renders and is generally not a great place to put
things like fetching logic
- Use react-query to replace `useReducers`. This let's us have
declarative fetching that reduces re-renders
- Custom column renderers
- Refactoring of rules list into smaller components
- Refactor bulk edit: elastic#142032
- Refactor ui state into its own hook

Things to still do:
- [x] Refactor testing 
- [x] Remove temp _query files and use same overwrite old hooks
- [x] improve test description for first and second set of data

How to test:
Check that everything in the rules list is working

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
Co-authored-by: Julia Guskova <iuliia.guskova@elastic.co>
FTR groups on CI target a 40 minute runtime. In situations where tests
are updated or moved, and there's no prior data, we're seeing occasional
timeouts with a 60 minute timeout. This increases the timeout to 90
minutes.
lcawl pushed a commit that referenced this pull request Aug 30, 2024
fixes
[#8](elastic/observability-accessibility#8)
fixes
[#7](elastic/observability-accessibility#7)
 
## Summary

Fixes APM breadcrumbs on serverless

| Serverless  |  Stateful  |
|---|---|
| <img width="700px" alt="image"
src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2">
|<img width="800px" alt="image"
src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2">
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/450664b1-ddfc-4395-9fa3-a7b941affb3b">|
| <img width="500px" alt="image"
src="https://github.com/user-attachments/assets/944a7d58-7de3-4a7f-be02-3c8c1110a0e2">
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/cb8a39e2-ca33-4cf9-a8ac-4c84566d092d">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/151a3a9c-c81e-4558-9d00-e695e3d1d79c">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/2562e96f-d5e4-4aa4-a221-6721f8995883">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/8d877d11-8c3f-4ac5-8146-6a11125eae7c">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/36e588cb-4c18-4d66-a2c6-f0e66392f708">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/14253196-06de-4343-811f-61aa31ea0d1e">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/0cdfc83f-6545-433f-8c14-5bbf2a581175">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/89a58e2b-2cef-4188-b2be-f359ba6890db">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/f15e767f-5b60-4485-ac71-7b6fd850ec50">|
|<img width="500px" alt="image"
src="https://github.com/user-attachments/assets/a0f7bfae-bfda-4f49-b92a-e736d80fea4c">|<img
width="500px" alt="image"
src="https://github.com/user-attachments/assets/680db8ab-58b8-454b-a0d7-6e1681dbe616">|


### How to test
#### Serverless
- Start a local ES serverless instance: `yarn es serverless
--projectType=oblt --ssl -k/--insecure`
- Start a local Kibana serverless instance: ` yarn start
--serverless=oblt --no-ssl`
- Run some synthtrace scenarios
- `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace mobile.ts
--live --target=https://elastic_serverless:changeme@127.0.0.1:9200
--kibana=http://elastic_serverless:changeme@0.0.0.0:5601`
- `NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace service_map.ts
--live --target=https://elastic_serverless:changeme@127.0.0.1:9200
--kibana=http://elastic_serverless:changeme@0.0.0.0:5601`
- Navigate to Applications and click through the links

### Stateful
- Start a local ES and Kibana instance
- Run the some synthtrace scenarios:
  -  `node scripts/synthtrace mobile.ts --live`
  -  `node scripts/synthtrace service_map.ts --live`
- Navigate to Applications and click through the links

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.