Add light layer on indirect lighting controller #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgeniiG
commented
Jun 8, 2020
com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ShaderVariables.hlsl
Outdated
Show resolved
Hide resolved
EvgeniiG
commented
Jun 8, 2020
com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ShaderVariables.hlsl
Outdated
Show resolved
Hide resolved
EvgeniiG
commented
Jun 9, 2020
com.unity.render-pipelines.high-definition/Editor/Lighting/IndirectLightingControllerEditor.cs
Outdated
Show resolved
Hide resolved
sebastienlagarde
approved these changes
Jun 15, 2020
sebastienlagarde
changed the title
JordanL8
reviewed
Jun 16, 2020
...ity.render-pipelines.high-definition/Documentation~/Override-Indirect-Lighting-Controller.md
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Jun 16, 2020
...ity.render-pipelines.high-definition/Documentation~/Override-Indirect-Lighting-Controller.md
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Jun 16, 2020
...ity.render-pipelines.high-definition/Documentation~/Override-Indirect-Lighting-Controller.md
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Jun 16, 2020
...ity.render-pipelines.high-definition/Documentation~/Override-Indirect-Lighting-Controller.md
Outdated
Show resolved
Hide resolved
JordanL8
reviewed
Jun 16, 2020
...ity.render-pipelines.high-definition/Documentation~/Override-Indirect-Lighting-Controller.md
Outdated
Show resolved
Hide resolved
JordanL8
approved these changes
Jun 16, 2020
TomasKiniulis
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Haven't ran into any issues. Made sure that:
- Controller blending/priority between multiple volumes behaves correctly
- Indirect Diffuse Lighting gets multiplied on appropriate selected layers
- Reflection Lighting multiplier gets appropriately multiplied on specified layers
- Reflection Probe Intensity Multiplier multiplies Planar and Reflection probes on top of Reflection Lighting multiplier
6 tasks
sebastienlagarde
added a commit
that referenced
this pull request
Jun 16, 2020
* Adding purge of unused resources in render graph. (#872) * First round of auto-exposure docs updates (#858) * start of volume docs (need switching branch) * moar docs * Reviewed exposure override * Reviewed render pipeline debug window doc and changed some formatting * Changed html links to md * Update HDRP-Camera.md * Removed rogue space * Small changes to the exposure page Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix depth offset and transparent motion vector for unlit transparent (#896) * Fix depth offset and transparent motion vector for unlit transparent * cleanup and fix the shadow pre/post alpha clip * Fixed an exception occuring when a camera doesn't have an HDAdditionalCameraData (1254383). (#846) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Generates Include command issue with Physically Based Sky (#908) * Split GenerateHLSL code from PhysicallyBasedSkyRenderer in a separate file to fix Generator Includes tool * Update ShaderVariablesPhysicallyBasedSky.cs.hlsl * Fix ray tracing with XR single-pass (#891) * removed warnings related to ray binning in XR * fix RenderRayTracedReflections with XR * add errors if Path Tracing is used with XR single-pass * add missing shader macros * add entry to changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/clean shader stacks fields (#906) * Cleanup the HD fields * Fix distortion appearing two times in the UI * Pbr sky fixes metal (#911) * Split GenerateHLSL code from PhysicallyBasedSkyRenderer in a separate file to fix Generator Includes tool * Update ShaderVariablesPhysicallyBasedSky.cs.hlsl * Fix constant buffer layout for physically based sky - Update Vector3 to Vector4 to reflect actual padding/layout for non-DX platforms (both are 16 bytes in the shader space, but 12 bytes in C#) - Updates to shader code to reference only the float3 data being set up * Update references screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Cleaun shader config for shadow (#917) * Move HDShadowFilteringQuality to main package as it is not used anymore * Update Upgrading-from-2020.1-to-2020.2.md * Add comment for _IncludeIndirectLighting for emissive mesh and clean ShaderPas template code * Fix shader warning * Fix shader config in DXR projects * Fix warnings (#920) * Enable render graph test (#873) * re revert the PR * Fixed planar probes with render graph. * Fixed an issue with msaa resolve pass when movecs aren't enabled. Co-authored-by: Julien Ignace <julien@unity3d.com> * Add light layer on indirect lighting controller (#777) * Add support for reflection controller. * Fix compilation * Fixed compilation issue and naming * Fixed compilation issue and naming * Update IndirectLightingControllerEditor.cs * Update CHANGELOG.md * Update Override-Indirect-Lighting-Controller.md * Update Override-Indirect-Lighting-Controller.md * Update Override-Indirect-Lighting-Controller.md * Update. Indirect controller also affect planar Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Update IndirectLightingController.cs * Compute shader stripping (#919) * Compute shader stripping * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR automated tests for XR (#915) * disable unsupported dxr tests in xr * enable dxr tests in xr on Yamato * add HDRP_DXR playmode_XR to ABV * Change guards around ESRAM code (#922) * Change unity version guards for ESRAM * move commas * Bump min version (#923) * Add a comment about packing float3/float4 Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Jesse Barker <jesseb@unity3d.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Jun 18, 2020
* Adding purge of unused resources in render graph. (#872) * First round of auto-exposure docs updates (#858) * start of volume docs (need switching branch) * moar docs * Reviewed exposure override * Reviewed render pipeline debug window doc and changed some formatting * Changed html links to md * Update HDRP-Camera.md * Removed rogue space * Small changes to the exposure page Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix depth offset and transparent motion vector for unlit transparent (#896) * Fix depth offset and transparent motion vector for unlit transparent * cleanup and fix the shadow pre/post alpha clip * Fixed an exception occuring when a camera doesn't have an HDAdditionalCameraData (1254383). (#846) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Generates Include command issue with Physically Based Sky (#908) * Split GenerateHLSL code from PhysicallyBasedSkyRenderer in a separate file to fix Generator Includes tool * Update ShaderVariablesPhysicallyBasedSky.cs.hlsl * Fix ray tracing with XR single-pass (#891) * removed warnings related to ray binning in XR * fix RenderRayTracedReflections with XR * add errors if Path Tracing is used with XR single-pass * add missing shader macros * add entry to changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/clean shader stacks fields (#906) * Cleanup the HD fields * Fix distortion appearing two times in the UI * Pbr sky fixes metal (#911) * Split GenerateHLSL code from PhysicallyBasedSkyRenderer in a separate file to fix Generator Includes tool * Update ShaderVariablesPhysicallyBasedSky.cs.hlsl * Fix constant buffer layout for physically based sky - Update Vector3 to Vector4 to reflect actual padding/layout for non-DX platforms (both are 16 bytes in the shader space, but 12 bytes in C#) - Updates to shader code to reference only the float3 data being set up * Update references screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Cleaun shader config for shadow (#917) * Move HDShadowFilteringQuality to main package as it is not used anymore * Update Upgrading-from-2020.1-to-2020.2.md * Add comment for _IncludeIndirectLighting for emissive mesh and clean ShaderPas template code * Fix shader warning * Fix shader config in DXR projects * Fix warnings (#920) * Enable render graph test (#873) * re revert the PR * Fixed planar probes with render graph. * Fixed an issue with msaa resolve pass when movecs aren't enabled. Co-authored-by: Julien Ignace <julien@unity3d.com> * Add light layer on indirect lighting controller (#777) * Add support for reflection controller. * Fix compilation * Fixed compilation issue and naming * Fixed compilation issue and naming * Update IndirectLightingControllerEditor.cs * Update CHANGELOG.md * Update Override-Indirect-Lighting-Controller.md * Update Override-Indirect-Lighting-Controller.md * Update Override-Indirect-Lighting-Controller.md * Update. Indirect controller also affect planar Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Update IndirectLightingController.cs * Compute shader stripping (#919) * Compute shader stripping * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR automated tests for XR (#915) * disable unsupported dxr tests in xr * enable dxr tests in xr on Yamato * add HDRP_DXR playmode_XR to ABV * Change guards around ESRAM code (#922) * Change unity version guards for ESRAM * move commas * Bump min version (#923) * Add a comment about packing float3/float4 * Added Opaque Cull Mode option for materials and ShaderGraph (#918) * Added the CullMode property for opaque objects * Updated changelog * Updated Opaque 8101 test * Fix SG preview and settings indent level * Add culmode opaque unlit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add test scene for SG vertex normal & tangent (#905) * Add test scene for vertex normal and vertex tangent * Add references images for other API * Updated the 2020.1 upgrade guide for custom pass volumes (#924) * HDRP Upgrade documentation for terrain new upgrade path (#901) * Upgrading documentation update * Typo * Added link to Terrain class * Fix warning in HDAdditionalLightData OnValidate (#885) * fix warning in HDAdditionalLightData OnValidate * Changelog * Avoid calling update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [10.x.x@ Update screenshots of test 8101 Opaque for HDRP test for Linux and Win Vulkank * Add the list of HDRP forbidden keywords in SG blackboard (#926) * Add the list of forbidden keywords to use in SG blackboard in the doc * Update Customizing-HDRP-materials-with-Shader-Graph.md * Update Customizing-HDRP-materials-with-Shader-Graph.md * Add [MainColor] and [MainTexture] on property (#939) * Scene exposure override (#889) * Scene Exposure Override * Changelog * better changelog * fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Exposure curve remapping can specify curves for min/max limits (#882) * Port code * changelog * Revert HDRP asset Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * IES Code path refactoring to support multiple SRP (#929) * Refactor * Refacto to support multiple SRPs * Missing doc + Re-enable PreviewGUI in the Inspector * Add Icons for IES Profiles * Rename Compositor to Graphics Compositor (#950) * Rename (HDRP) Compositor to Graphics Compositor * Missed a few occurancies * Ray traced reflection presets and fixes (#912) * - Fixed a bug related to denoising ray traced reflections. - Added presets for ray traced reflections. * Testing the asset of the ray tracing usage parameters in ssr * Mistake in history rejection for RTR * Only use one texture for ray traced reflection upscaling Adjust the upscale radius based on the roughness value * Adjusted the preset values * Updating the screenshots after changing the upscale radius metric. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a warning in the ray tracing ambient occlusion compute shader. (#953) * - Fixed a warning in the ray tracing ambient occlusion compute shader. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Changed the way the filter size is decided for directional, point and spot shadows (#951) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Various code cleanup in HDRP indirect diffuse lighting + Start remove macro RAYTRACING (#937) * Change code to have a indirectDiffuseMode and start to clean RaytracingMacro * Little extra cleanup * Final Image Histogram Debug View (#887) * Final image histogram ported * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Cleanup area shadow code and Macro + remove more Raytracing macro (#945) * Change code to have a indirectDiffuseMode and start to clean RaytracingMacro * Little extra cleanup * Clean area shadow code and remove usless macro * update shader config files for projects * Better naming for SKIP_RASTERIZED_AREA_SHADOWS * Update Upgrading-from-2020.1-to-2020.2.md * remove useless comment * HDRP: Fix shader warning in RaytracingAmbientOcclusion.compute * HDRP: Fix standalone build (Break in Exposure scene settings PR) * HDRP: Update HDRenderPipeineResources.asset not up to date * Cleanup HAVE_RECURSIVE_RENDERING usage (#958) * Change code to have a indirectDiffuseMode and start to clean RaytracingMacro * Little extra cleanup * Clean area shadow code and remove usless macro * update shader config files for projects * Better naming for SKIP_RASTERIZED_AREA_SHADOWS * Update Upgrading-from-2020.1-to-2020.2.md * remove useless comment * cleanup have deferred rendering * Move Screen Space Shadow to multicompile and remove config requirement for DXR (#960) * Change code to have a indirectDiffuseMode and start to clean RaytracingMacro * Little extra cleanup * Clean area shadow code and remove usless macro * update shader config files for projects * Better naming for SKIP_RASTERIZED_AREA_SHADOWS * Update Upgrading-from-2020.1-to-2020.2.md * remove useless comment * cleanup have deferred rendering * Clean RaytracingIndirectDiffuse.compute code * Move screen space shadow to a multicompile + remove Raytracing macro * Remove config package from DXR Test Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Jesse Barker <jesseb@unity3d.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Jul 7, 2020
6 tasks
sebastienlagarde
added a commit
that referenced
this pull request
Jul 8, 2020
* [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583 * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587 * Update Light-Component.md (#682) * push meta * removed undesired change in AXF * Fix transparent movec scene view #698 * Porting console fixes to staging (#699) * Update HDRP-Camera.md (#706) * Pre warm RT Handle system so that reallocations are reduced. #713 * Update PlanarReflectionProbeCache.cs * Update preview naming in raytrace component #753 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Standard terrain upgrader (#762) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Force post process parent setting to be before child settings #799 * Fixed 1253367 by rebaking probe with missing baked texture. #818 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Fixed blend distance editing (1248931) #838 * Fix API breaking change: Add Public quality to Raytracing volume effect * Fix API breaking change: Add Public quality to Raytracing volume effect - RR * Update HDR information. Also updated format and links. (#853) * Fix message for metal and ao (#859) * d Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Update HDRenderPipeline.cs (#994) * Delete 9713_VirtualTexturing.meta * Fix SSAO with double sided material and normal mode to none #1043 * Fix emissive mesh layer mask behaviour #1062 * Use the wide mode to force the UI drawing on a single line (1251235) #1064 * Fix custom pass after post process buffer #1072 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Fix taaFrameIndex and restore TAA tests for XR #534 * fix typo in the Render Pipeline Wizard #1037 * Add light layer on indirect lighting controller #777 * [8.x.x Backport] Fix exposure white flash when enabling SSR (#842) * fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837) * port * changelog * Update HDRenderPipeline.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. # Conflicts: # com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107) * Implemented proper culling for decals when used in prefabs and edited in context. * Compilation fix * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix API breaking change in indirect controller * Fix area light gizmo not updating engine side light v2 #1156 * Add missing ClothObj. * HDRP: Default indirect Lighting controller Layers to Everything to ease the migration * Update HDRenderPipelineResources.asset * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
sebastienlagarde
added a commit
that referenced
this pull request
Jul 9, 2020
* [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583 * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587 * Update Light-Component.md (#682) * push meta * removed undesired change in AXF * Fix transparent movec scene view #698 * Porting console fixes to staging (#699) * Update HDRP-Camera.md (#706) * Pre warm RT Handle system so that reallocations are reduced. #713 * Update PlanarReflectionProbeCache.cs * Update preview naming in raytrace component #753 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Standard terrain upgrader (#762) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Force post process parent setting to be before child settings #799 * Fixed 1253367 by rebaking probe with missing baked texture. #818 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Fixed blend distance editing (1248931) #838 * Fix API breaking change: Add Public quality to Raytracing volume effect * Fix API breaking change: Add Public quality to Raytracing volume effect - RR * Update HDR information. Also updated format and links. (#853) * Fix message for metal and ao (#859) * d Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Update HDRenderPipeline.cs (#994) * Delete 9713_VirtualTexturing.meta * Fix SSAO with double sided material and normal mode to none #1043 * Fix emissive mesh layer mask behaviour #1062 * Use the wide mode to force the UI drawing on a single line (1251235) #1064 * Fix custom pass after post process buffer #1072 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Fix taaFrameIndex and restore TAA tests for XR #534 * fix typo in the Render Pipeline Wizard #1037 * Add light layer on indirect lighting controller #777 * [8.x.x Backport] Fix exposure white flash when enabling SSR (#842) * fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837) * port * changelog * Update HDRenderPipeline.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. # Conflicts: # com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107) * Implemented proper culling for decals when used in prefabs and edited in context. * Compilation fix * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix API breaking change in indirect controller * Fix area light gizmo not updating engine side light v2 #1156 * Add missing ClothObj. * HDRP: Default indirect Lighting controller Layers to Everything to ease the migration * Update HDRenderPipelineResources.asset * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Rename h to hlsl * Update cas include paths (#1227) * Fix XR single-pass macros in tessellation shaders #1160 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Nov 16, 2020
* [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583 * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587 * Update Light-Component.md (#682) * push meta * removed undesired change in AXF * Fix transparent movec scene view #698 * Porting console fixes to staging (#699) * Update HDRP-Camera.md (#706) * Pre warm RT Handle system so that reallocations are reduced. #713 * Update PlanarReflectionProbeCache.cs * Update preview naming in raytrace component #753 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Standard terrain upgrader (#762) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Force post process parent setting to be before child settings #799 * Fixed 1253367 by rebaking probe with missing baked texture. #818 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Fixed blend distance editing (1248931) #838 * Fix API breaking change: Add Public quality to Raytracing volume effect * Fix API breaking change: Add Public quality to Raytracing volume effect - RR * Update HDR information. Also updated format and links. (#853) * Fix message for metal and ao (#859) * d Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Update HDRenderPipeline.cs (#994) * Delete 9713_VirtualTexturing.meta * Fix SSAO with double sided material and normal mode to none #1043 * Fix emissive mesh layer mask behaviour #1062 * Use the wide mode to force the UI drawing on a single line (1251235) #1064 * Fix custom pass after post process buffer #1072 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Fix taaFrameIndex and restore TAA tests for XR #534 * fix typo in the Render Pipeline Wizard #1037 * Add light layer on indirect lighting controller #777 * [8.x.x Backport] Fix exposure white flash when enabling SSR (#842) * fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837) * port * changelog * Update HDRenderPipeline.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. # Conflicts: # com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107) * Implemented proper culling for decals when used in prefabs and edited in context. * Compilation fix * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix API breaking change in indirect controller * Fix area light gizmo not updating engine side light v2 #1156 * Add missing ClothObj. * HDRP: Default indirect Lighting controller Layers to Everything to ease the migration * Update HDRenderPipelineResources.asset * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Rename h to hlsl * Update cas include paths (#1227) * Fix XR single-pass macros in tessellation shaders #1160 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 * [8.x.x backport] Fix issues with history sampling and hw dynamic res (#1777) * Fix TAA dynamic res issue * Changelog * [Backport 8.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1322) * Fixed an issue where look dev lighting would go black when a new scene is loaded. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Nov 17, 2020
…535 when resolution is very high (#2623) * [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583 * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587 * Update Light-Component.md (#682) * push meta * removed undesired change in AXF * Fix transparent movec scene view #698 * Porting console fixes to staging (#699) * Update HDRP-Camera.md (#706) * Pre warm RT Handle system so that reallocations are reduced. #713 * Update PlanarReflectionProbeCache.cs * Update preview naming in raytrace component #753 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Standard terrain upgrader (#762) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Force post process parent setting to be before child settings #799 * Fixed 1253367 by rebaking probe with missing baked texture. #818 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Fixed blend distance editing (1248931) #838 * Fix API breaking change: Add Public quality to Raytracing volume effect * Fix API breaking change: Add Public quality to Raytracing volume effect - RR * Update HDR information. Also updated format and links. (#853) * Fix message for metal and ao (#859) * d Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Update HDRenderPipeline.cs (#994) * Delete 9713_VirtualTexturing.meta * Fix SSAO with double sided material and normal mode to none #1043 * Fix emissive mesh layer mask behaviour #1062 * Use the wide mode to force the UI drawing on a single line (1251235) #1064 * Fix custom pass after post process buffer #1072 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Fix taaFrameIndex and restore TAA tests for XR #534 * fix typo in the Render Pipeline Wizard #1037 * Add light layer on indirect lighting controller #777 * [8.x.x Backport] Fix exposure white flash when enabling SSR (#842) * fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837) * port * changelog * Update HDRenderPipeline.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. # Conflicts: # com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107) * Implemented proper culling for decals when used in prefabs and edited in context. * Compilation fix * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix API breaking change in indirect controller * Fix area light gizmo not updating engine side light v2 #1156 * Add missing ClothObj. * HDRP: Default indirect Lighting controller Layers to Everything to ease the migration * Update HDRenderPipelineResources.asset * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Rename h to hlsl * Update cas include paths (#1227) * Fix XR single-pass macros in tessellation shaders #1160 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 * [8.x.x backport] Fix issues with history sampling and hw dynamic res (#1777) * Fix TAA dynamic res issue * Changelog * [Backport 8.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1322) * Fixed an issue where look dev lighting would go black when a new scene is loaded. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix * Changelog Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Nov 17, 2020
… not null, but containing garbage (#2621) * [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583 * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587 * Update Light-Component.md (#682) * push meta * removed undesired change in AXF * Fix transparent movec scene view #698 * Porting console fixes to staging (#699) * Update HDRP-Camera.md (#706) * Pre warm RT Handle system so that reallocations are reduced. #713 * Update PlanarReflectionProbeCache.cs * Update preview naming in raytrace component #753 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Standard terrain upgrader (#762) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Force post process parent setting to be before child settings #799 * Fixed 1253367 by rebaking probe with missing baked texture. #818 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Fixed blend distance editing (1248931) #838 * Fix API breaking change: Add Public quality to Raytracing volume effect * Fix API breaking change: Add Public quality to Raytracing volume effect - RR * Update HDR information. Also updated format and links. (#853) * Fix message for metal and ao (#859) * d Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Update HDRenderPipeline.cs (#994) * Delete 9713_VirtualTexturing.meta * Fix SSAO with double sided material and normal mode to none #1043 * Fix emissive mesh layer mask behaviour #1062 * Use the wide mode to force the UI drawing on a single line (1251235) #1064 * Fix custom pass after post process buffer #1072 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Fix taaFrameIndex and restore TAA tests for XR #534 * fix typo in the Render Pipeline Wizard #1037 * Add light layer on indirect lighting controller #777 * [8.x.x Backport] Fix exposure white flash when enabling SSR (#842) * fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837) * port * changelog * Update HDRenderPipeline.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. # Conflicts: # com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107) * Implemented proper culling for decals when used in prefabs and edited in context. * Compilation fix * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix API breaking change in indirect controller * Fix area light gizmo not updating engine side light v2 #1156 * Add missing ClothObj. * HDRP: Default indirect Lighting controller Layers to Everything to ease the migration * Update HDRenderPipelineResources.asset * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Rename h to hlsl * Update cas include paths (#1227) * Fix XR single-pass macros in tessellation shaders #1160 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 * [8.x.x backport] Fix issues with history sampling and hw dynamic res (#1777) * Fix TAA dynamic res issue * Changelog * [Backport 8.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1322) * Fixed an issue where look dev lighting would go black when a new scene is loaded. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix * Changelog Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Nov 17, 2020
* Fix for potentially corrupted refraction result on xbox #1699 * Update HDRenderPipeline.LookDev.cs (#1740) * Update Layered-Lit-Shader #1766 * Fix for assertion on undoing a mod of diffuse profile list with volume profile deleted #1769 * Fixed two issues with sky static lighting. #1775 * Better tooltip for exposure weight on emission fields. #1821 * Fix rendering of custom passes in the Custom Pass Volume inspector #1824 * Updated the implementation details for pb sky (#1872) * Fixed typo in TextureCache2D.cs (#1896) * Add disclaimer about object motion vectors not working in the scene view (#1900) * Update Render-Pipeline-Debug-Window.md * Update Render-Pipeline-Debug-Window.md * Fix double addition to sorted volume lists #1916 * Fix issues with bloom sampling outside #1930 * fix case 1244430 removing camera comp from prefab #1953 * Fix nan in the pbr sky #1983 * [HDRP][LookDev] Ensure stylesheet are loaded before applying them on Domain Reload #1985 * Fix Custom Post Process affecting preview cameras #1988 * Fix box light disappearing when range is below 1 and no range attenuation #1989 * Fix matcap preferences serialization issue #2013 * [Backport 8.x.x] Fixed error Maximum allowed thread group count is 65535 when resolution is very high (#2623) * [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583 * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587 * Update Light-Component.md (#682) * push meta * removed undesired change in AXF * Fix transparent movec scene view #698 * Porting console fixes to staging (#699) * Update HDRP-Camera.md (#706) * Pre warm RT Handle system so that reallocations are reduced. #713 * Update PlanarReflectionProbeCache.cs * Update preview naming in raytrace component #753 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Standard terrain upgrader (#762) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Force post process parent setting to be before child settings #799 * Fixed 1253367 by rebaking probe with missing baked texture. #818 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Fixed blend distance editing (1248931) #838 * Fix API breaking change: Add Public quality to Raytracing volume effect * Fix API breaking change: Add Public quality to Raytracing volume effect - RR * Update HDR information. Also updated format and links. (#853) * Fix message for metal and ao (#859) * d Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Update HDRenderPipeline.cs (#994) * Delete 9713_VirtualTexturing.meta * Fix SSAO with double sided material and normal mode to none #1043 * Fix emissive mesh layer mask behaviour #1062 * Use the wide mode to force the UI drawing on a single line (1251235) #1064 * Fix custom pass after post process buffer #1072 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Fix taaFrameIndex and restore TAA tests for XR #534 * fix typo in the Render Pipeline Wizard #1037 * Add light layer on indirect lighting controller #777 * [8.x.x Backport] Fix exposure white flash when enabling SSR (#842) * fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837) * port * changelog * Update HDRenderPipeline.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. # Conflicts: # com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107) * Implemented proper culling for decals when used in prefabs and edited in context. * Compilation fix * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix API breaking change in indirect controller * Fix area light gizmo not updating engine side light v2 #1156 * Add missing ClothObj. * HDRP: Default indirect Lighting controller Layers to Everything to ease the migration * Update HDRenderPipelineResources.asset * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Rename h to hlsl * Update cas include paths (#1227) * Fix XR single-pass macros in tessellation shaders #1160 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 * [8.x.x backport] Fix issues with history sampling and hw dynamic res (#1777) * Fix TAA dynamic res issue * Changelog * [Backport 8.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1322) * Fixed an issue where look dev lighting would go black when a new scene is loaded. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix * Changelog Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> * Update Feature-Comparison.md (#2111) * Update Feature-Comparison.md Changed Feature compatabilitty with AR Foundation from "No" to "Yes" * Update Feature-Comparison.md HDRP compatability with AR Foundation changed to "No". * Remove XRSystemTests #2241 * HDRP - Fix XR shadows culling #2263 * Fix volument component creation via script #2369 * Adding support for CloudRendering to HDRP #2436 * Fix light resolution scalable settings in the Light Explorer #2470 * [HDRP] Fix issue when changing FoV with the physical camera fold-out closed #2570 * [Backport 8.x.x] Fix issue with previous frame exposure texture being not null, but containing garbage (#2621) * [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) #583 * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test #587 * Update Light-Component.md (#682) * push meta * removed undesired change in AXF * Fix transparent movec scene view #698 * Porting console fixes to staging (#699) * Update HDRP-Camera.md (#706) * Pre warm RT Handle system so that reallocations are reduced. #713 * Update PlanarReflectionProbeCache.cs * Update preview naming in raytrace component #753 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Standard terrain upgrader (#762) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Force post process parent setting to be before child settings #799 * Fixed 1253367 by rebaking probe with missing baked texture. #818 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Fixed blend distance editing (1248931) #838 * Fix API breaking change: Add Public quality to Raytracing volume effect * Fix API breaking change: Add Public quality to Raytracing volume effect - RR * Update HDR information. Also updated format and links. (#853) * Fix message for metal and ao (#859) * d Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Update HDRenderPipeline.cs (#994) * Delete 9713_VirtualTexturing.meta * Fix SSAO with double sided material and normal mode to none #1043 * Fix emissive mesh layer mask behaviour #1062 * Use the wide mode to force the UI drawing on a single line (1251235) #1064 * Fix custom pass after post process buffer #1072 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Find the appropriate default frame settings per editor (case 1247631) #1129 * Fix taaFrameIndex and restore TAA tests for XR #534 * fix typo in the Render Pipeline Wizard #1037 * Add light layer on indirect lighting controller #777 * [8.x.x Backport] Fix exposure white flash when enabling SSR (#842) * fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#837) * port * changelog * Update HDRenderPipeline.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Fix depth pyramid issues with dynamic resolution (#847) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1105) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed Look Dev with Light Theme (#1106) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. # Conflicts: # com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed decal duplication when editing a prefab in context (#1107) * Implemented proper culling for decals when used in prefabs and edited in context. * Compilation fix * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix API breaking change in indirect controller * Fix area light gizmo not updating engine side light v2 #1156 * Add missing ClothObj. * HDRP: Default indirect Lighting controller Layers to Everything to ease the migration * Update HDRenderPipelineResources.asset * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Rename h to hlsl * Update cas include paths (#1227) * Fix XR single-pass macros in tessellation shaders #1160 * Hdrp/fix hierarchicalbox gizmo symetry and homothety mode ensuring face faces outside #1228 * [8.x.x backport] Fix issues with history sampling and hw dynamic res (#1777) * Fix TAA dynamic res issue * Changelog * [Backport 8.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1322) * Fixed an issue where look dev lighting would go black when a new scene is loaded. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix * Changelog Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> * Added a warning when trying to bake with static lighting being in an invalid state. #2597 * Fix volumetric fog nan #2174 * Fixed a null ref in the volume component list when there is no volume components in the project #1282 Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Martin Thorzen <35328557+martint-unity@users.noreply.github.com> Co-authored-by: jenniferd-unity <71718938+jenniferd-unity@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Vic-Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: Andrew Spiering <aspiering@gmail.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR add support of Light Layers on indirect lighting controller.
There is now an indirect diffuse and reflection lighting muliplier that can be affected by light layers
Those now affect correctly all baked and screen space effect, and reflections probe and planar reflections correctly.
The previous property that was only affecting reflection probe have been keep for compatibility but don't support light layers.
Testing status
Manual Tests: What did you do?
Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)
Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
Any test projects to go with this to help reviewers?
Comments to reviewers
Notes for the reviewers you have assigned.