Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbnode] Series ref resolver #3316

Merged
merged 38 commits into from
Mar 15, 2021
Merged

[dbnode] Series ref resolver #3316

merged 38 commits into from
Mar 15, 2021

Commits on Mar 2, 2021

  1. WIP [dbnode] Use series read write ref resolver

    @robskillington
    robskillington committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0777cc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. fixing the build and making unit tests pass.

    @soundvibe
    soundvibe committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    fa01bbb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into linasn/series-resolver 

    * master:
  [aggregator] Move placement checks to a background job (#3315)
  [tests] Remove a few more usages of NoOpAllBootstrapper from tests (#3314)
  [coordinator] make drop timestamp apply to the metric rather than specific rule (#3310)
  Update server.go (#3298)
  Fix Data Race in checkoutSeriesWithLock (#3300)
  [query] Allow configuration of placement options (#3304)
    @soundvibe
    soundvibe committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    34e85db View commit details
    Browse the repository at this point in the history

  3. trying to fix resolve error.

    @soundvibe
    soundvibe committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    1385c2f View commit details
    Browse the repository at this point in the history

  4. trying to fix resolve error (2).

    @soundvibe
    soundvibe committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    9cc2a22 View commit details
    Browse the repository at this point in the history

  5. trying to fix resolve error (3).

    @soundvibe
    soundvibe committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    8c02b88 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. add logging to check if series was expired.

    @soundvibe
    soundvibe committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    48fdcf8 View commit details
    Browse the repository at this point in the history

  2. try incrementing reader-writer count for a new entry so it won't be p… 

    …urged.
    @soundvibe
    soundvibe committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    537823a View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. handle accumulator close errors. 

    optimize commit log snapshot load.
    @soundvibe
    soundvibe committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    abf5160 View commit details
    Browse the repository at this point in the history

  2. test commit with warm flush and seriesId cache.

    @soundvibe
    soundvibe committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    ef4d08d View commit details
    Browse the repository at this point in the history

  3. trying to fix warm flush.

    @soundvibe
    soundvibe committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    87979c8 View commit details
    Browse the repository at this point in the history

  4. revert flush changes.

    @soundvibe
    soundvibe committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    b404219 View commit details
    Browse the repository at this point in the history

  5. use multiErrors.

    @soundvibe
    soundvibe committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    acc2f0a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. fixed index write when using series ref. 

    added UniqueIndex to SeriesRef.
    @soundvibe
    soundvibe committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c0877e8 View commit details
    Browse the repository at this point in the history

  2. insert new entry and inc ref count.

    @soundvibe
    soundvibe committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    80f4e42 View commit details
    Browse the repository at this point in the history

  3. fixed linter issues.

    @soundvibe
    soundvibe committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    b481a6c View commit details
    Browse the repository at this point in the history

  4. small cleanup. 

    removed unnecessary resolvers.
    @soundvibe
    soundvibe committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6078828 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. optimized series ref resolver usage.

    @soundvibe
    soundvibe committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    2f5f2c8 View commit details
    Browse the repository at this point in the history

  2. added unit test.

    @soundvibe
    soundvibe committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    05bec35 View commit details
    Browse the repository at this point in the history

  3. fixing possible race.

    @soundvibe
    soundvibe committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    629efb9 View commit details
    Browse the repository at this point in the history

  4. simplified error handling in commit log bs.

    @soundvibe
    soundvibe committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    28caa33 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into linasn/series-resolver 

    * master: (22 commits)
  Remove deprecated fields (#3327)
  Add quotas to Permits (#3333)
  [aggregator] Drop messages that have a drop policy applied (#3341)
  Fix NPE due to race with a closing series (#3056)
  [coordinator] Apply auto-mapping rules if-and-only-if no drop policies are in effect (#3339)
  [aggregator] Add validation in AddTimedWithStagedMetadatas (#3338)
  [coordinator] Fix panic in Ready endpoint for admin coordinator (#3335)
  [instrument] Config option to emit detailed Go runtime metrics only (#3332)
  [aggregator] Sort heap in one go, instead of iterating one-by-one (#3331)
  [pool] Add support for dynamic, sync.Pool backed, object pools (#3334)
  Enable PANIC_ON_INVARIANT_VIOLATED for tests (#3326)
  [aggregator] CanLead for unflushed window takes BufferPast into account (#3328)
  Optimize StagedMetadatas conversion (#3330)
  [m3msg] Improve message scan performance (#3319)
  [dbnode] Add reason tag to bootstrap retries metric (#3317)
  [coordinator] Enable rule filtering on prom metric type (#3325)
  Update m3dbnode-all-config.yml (#3204)
  [coordinator] Include Type in RollupOp.Equal (#3322)
  [coordinator] Simplify iteration logic of matchRollupTarget (#3321)
  [coordinator] Add rollup type to remove specific dimensions (#3318)
  ...
    @soundvibe
    soundvibe committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    a892422 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. use cancellable context to cancel read series goroutine if load block… 

    …s returns an error.
    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    79343ed View commit details
    Browse the repository at this point in the history

  2. load blocks concurrently. 

    simplify code.
    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    b26825f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into linasn/series-resolver 

    * master:
  [dbnode] Remove unused shardBlockVolume (#3347)
  Fix new Go 1.15+ vet check failures (#3345)
  [coordinator] Add config option to make rollup rules untimed (#3343)
  [aggregator] Raw TCP Client write queueing/buffering refactor (#3342)
  [dbnode] Fail M3TSZ encoding on DeltaOfDelta overflow (#3329)
    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    0658b1d View commit details
    Browse the repository at this point in the history

  4. changes after review.

    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    51ed40f View commit details
    Browse the repository at this point in the history

  5. removed previously added logging line for testing.

    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    be6604b View commit details
    Browse the repository at this point in the history

  6. updated mocks.

    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    baeca8d View commit details
    Browse the repository at this point in the history

  7. updated some code comments.

    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    d3c69cf View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into linasn/series-resolver 

    * master:
  [dtest] ns update/delete api (#3344)
    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    2d14706 View commit details
    Browse the repository at this point in the history

  9. renamed entryRefCountIncremented option to releaseEntryRef.

    @soundvibe
    soundvibe committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    bfc972a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. extracted series resolver into separate file.

    @soundvibe
    soundvibe committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    15b82e1 View commit details
    Browse the repository at this point in the history

  2. check if context was not cancelled once in 1024 iterations instead of… 

    … every time.
    @soundvibe
    soundvibe committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    49561ad View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into linasn/series-resolver 

    * master:
  [dbnode] Remove unused getMockReader (#3351)
  [dbnode] Add back teardown of containers at end of Prometheus integration test (#3349)
  [query] Add series metadata label limit header for trimming response (#3348)

# Conflicts:
#	src/dbnode/storage/shard_test.go
    @soundvibe
    soundvibe committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e6fbdf5 View commit details
    Browse the repository at this point in the history

  4. fixed comment.

    @soundvibe
    soundvibe committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    2d2fc76 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into linasn/series-resolver 

    * master:
  [dbnode] Fix clock options not propagated where needed (#3353)
    @soundvibe
    soundvibe committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    4489d21 View commit details
    Browse the repository at this point in the history

  6. inline retrieveWritableSeries function into series resolver.

    @soundvibe
    soundvibe committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    49f9753 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into linasn/series-resolver 

    * master:
  [x] Add OffsetClock constructor that uses given time delta (#3354)
    @soundvibe
    soundvibe committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    535e786 View commit details
    Browse the repository at this point in the history