Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer: Add partition by support for derived TopN(filter on row_number) #41362

Conversation

ghazalfamilyusa
Copy link
Contributor

Issue Number: Ref #39792

Problem Summary:

This is a continuation of #41209 which introduced deriving top N from "row_number as RN ... where RN <= N". This PR adds support for partition by in the window function "row_number as RN over (partition by X) ... where RN <= N" and restricted if the partition by is a prefix of the PK. Execution support for this extension is here tikv/tikv#14116

Tests

Unit tests

Side effects

None

Documentation

None

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 13, 2023
@ghazalfamilyusa ghazalfamilyusa marked this pull request as draft February 14, 2023 17:31
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2023
@ghazalfamilyusa ghazalfamilyusa force-pushed the derived_topn_with_partition branch 2 times, most recently from 449ea8f to 5944195 Compare February 14, 2023 23:51
@ghazalfamilyusa ghazalfamilyusa marked this pull request as ready for review February 14, 2023 23:51
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2023
@ghazalfamilyusa ghazalfamilyusa force-pushed the derived_topn_with_partition branch 5 times, most recently from d9974ca to 6de55f1 Compare February 15, 2023 20:54
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2023
@ti-chi-bot
Copy link
Member

@ghazalfamilyusa: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2023
ystaticy and others added 24 commits February 15, 2023 13:33
@ghazalfamilyusa ghazalfamilyusa requested a review from a team as a code owner February 15, 2023 22:51
@ghazalfamilyusa ghazalfamilyusa marked this pull request as draft February 15, 2023 22:52
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@ti-chi-bot
Copy link
Member

@ghazalfamilyusa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 68a61de link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 68a61de link true /test mysql-test
idc-jenkins-ci-tidb/check_dev 68a61de link true /test check-dev
idc-jenkins-ci-tidb/build 68a61de link true /test build
idc-jenkins-ci-tidb/check_dev_2 68a61de link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ghazalfamilyusa ghazalfamilyusa deleted the derived_topn_with_partition branch February 16, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.