Gutter line number colors #7647 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow easier styling for consumers outside of the debugger, as well as handling user copy easier. Tests are modified accordingly.
* Remove most usages of immutable.js from the breakpoints reducer
…7261) * Add tab and new line character in Frame component; This does not modify the layout of the component, but includes those chars in the clipboard when the user copy text. Needed for console tests to pass. * Update tests
…ols#7264) * Simplify the getBreakpointsForSource selector function * tweak tests
* fix breakpoint context menu logic for finding other breakpoints
…#7285) Fixes firefox-devtools#7209. This adds a title to the group component that indicates it can be expanded/collapsed. Two location entries are added to handle both collapsed and expanded state.
Remove the `autoFocus` attribute from the "watch expression" and "xhr breakpoint" input elements. These elements are both given focus manually. Raise the severity of the jsx-a11y/no-autofocus rule from "warn" to "error" to avoid future warnings.
First, raise the severity of the rule to an error to prevent any future warnings. Next, change the 'show generated/original scopes' element to a use a <button> element instead of an <a> element. The styling of this element is updated such that it remains the same.
…ls#7580) * Fix CallStack Group with anonymous function. formatDisplayName was called without the l10n object, which caused an exception if the last frame of a stack was anonymous (because we then use l10n). The fix is simple, pass the l10n object to formatDisplayName. A test is added to ensure we cover this case. The test do fails without the fix in Group.js
changed line number and empty line number to - Dark Mode Line number: Grey 40 #b1b1b3 Empty line number: Grey 50 #737373 Light Mode Line number: Grey 50 #737373 Empty line number: Grey 40 #b1b1b3
Gutter line number colors firefox-devtools#7647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes firefox-devtools#7647
Here's the Pull Request Doc
https://firefox-dev.tools/debugger.html/docs/pull-requests.html
Summary of Changes