feat(CSI-239): moveToTrash does not return error to upper layers

[sergeyberezansky]

TL;DR

Improved error handling in volume garbage collection process.

What changed?

• Modified triggerGcVolume and moveVolumeToTrash functions to return errors.
• Updated Trash method in Volume struct to handle the error returned by triggerGcVolume.
• Removed synchronous comment from triggerGcVolume as it's no longer relevant.

How to test?

1. Attempt to trash a volume that requires garbage collection.
2. Verify that any errors during the process are properly propagated and handled.
3. Test scenarios where moving the volume to trash might fail (e.g., permission issues, disk full) and ensure errors are returned.

Why make this change?

This change improves error handling and propagation in the volume garbage collection process. By returning errors from triggerGcVolume and moveVolumeToTrash, we can better detect and respond to issues that may occur during the trashing process. This enhancement allows for more robust error handling and logging, potentially improving debugging and system reliability.

---

[sergeyberezansky]

• chore(deps): update sidecar versions #326
• docs(CSI-254): update official docs link in Helm templates and README #323
• feat(CSI-252): implement kubelet PVC stats #322
• refactor(CSI-250): do not maintain redundant active mounts from node server after publishing volume #320
• feat(CSI-247): implement InterfaceGroup.GetRandomIpAddress() #319
• feat(CSI-249): optimize NFS mounter to use multiple targets #318
• fix(CSI-241): fix unmountWithOptions to use map key rather than options.String() #317
• feat(CSI-245): allow specifying client group for NFS #316
• chore(deps): update packages to latest versions and Go to 1.22.5 #314
• chore(deps): combine chmod with ADD in Dockerfile #313
• feat(CSI-239): moveToTrash does not return error to upper layers #312 👈
• fix(CSI-243): service accounts for CSI plugin assume ImagePullSecret and cause error messages. #311
• feat(CSI-244): match subnets if existing in client rule #315
• fix(CSI-241): conflict in metrics between node and controller #325
• feat(CSI-213): support NFS transport #299
• fix(CSI-241): disregard sync_on_close in mountmap per FS #310
• feat(CSI-253): support custom CA certificate in API secret #324
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/02/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

[sergeyberezansky]

Merge activity

• Sep 12, 6:10 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 12, 7:16 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 12, 7:18 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 12, 7:23 AM EDT: @sergeyberezansky merged this pull request with Graphite.