-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CSI-250): do not maintain redundant active mounts from node server after publishing volume #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/05/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 5, 2024 09:09
b01ce5e
to
6d41434
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 5, 2024 09:09
3aad575
to
91b2275
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 5, 2024 09:37
6d41434
to
f4fd8aa
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
4 times, most recently
from
September 5, 2024 14:52
1c31418
to
966cdfd
Compare
This was referenced Sep 11, 2024
Merged
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 11, 2024 10:11
f4fd8aa
to
86d2b73
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 10:12
966cdfd
to
df532ea
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 11, 2024 11:12
86d2b73
to
a94501a
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 11:12
df532ea
to
1ea1bd6
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 11, 2024 11:35
a94501a
to
17de623
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 11:35
1ea1bd6
to
09cf230
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 11, 2024 11:51
17de623
to
bc62036
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 11:52
09cf230
to
1e4001d
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 11, 2024 13:02
bc62036
to
b2c02ee
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 13:02
1e4001d
to
1278b06
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 11, 2024 14:25
b2c02ee
to
844dce9
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 11, 2024 14:25
1278b06
to
502c178
Compare
Merge activity
|
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 12, 2024 12:00
844dce9
to
69edc7d
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 12:00
502c178
to
f4d35ee
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 12, 2024 12:45
69edc7d
to
92fb904
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 12:45
f4d35ee
to
81afdbb
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 12, 2024 12:48
92fb904
to
77ab95a
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 12:48
81afdbb
to
cf521b3
Compare
sergeyberezansky
force-pushed
the
sergey/multi-ip-nfs
branch
from
September 12, 2024 13:11
77ab95a
to
43c8d6a
Compare
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 13:11
cf521b3
to
d369ae2
Compare
sergeyberezansky
changed the base branch from
sergey/multi-ip-nfs
to
graphite-base/320
September 12, 2024 13:20
sergeyberezansky
force-pushed
the
sergey/nfs-mounter-mapless
branch
from
September 12, 2024 13:20
d369ae2
to
c3cae42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added "sync,async" to mutually exclusive mount options and optimized mount handling in the CSI driver.
What changed?
values.yaml
.nfsMounter
to remove themountMap
and associated locking mechanism.NewMount
method to create a newnfsMount
object on each call.mountWithOptions
to merge mutually exclusive options.unmountWithOptions
to directly use the new mount object.NodePublishVolume
to defer unmounting of the parent filesystem.NodeUnpublishVolume
.How to test?
Why make this change?
This change aims to improve the handling of mount options and simplify the mount management process. By adding "sync" and "async" to the mutually exclusive options, we prevent potential conflicts in mount configurations, which might be caused by translating WekaFS mount options to NFS mount options.
The refactoring of the
nfsMounter
removes the need for a complex mount map and associated locking, which should lead to better performance and reduced complexity. These changes should result in more reliable and efficient volume mounting and unmounting operations in the CSI driver.