-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CSI-241): conflict in metrics between node and controller #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
Merged
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/11/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/modify-default-hostports
branch
from
September 11, 2024 14:24
4a6085c
to
a445cd7
Compare
Merge activity
|
sergeyberezansky
changed the base branch from
sergey/nfs_support
to
graphite-base/325
September 12, 2024 10:26
sergeyberezansky
force-pushed
the
sergey/modify-default-hostports
branch
from
September 12, 2024 10:35
a445cd7
to
f9e96f7
Compare
sergeyberezansky
force-pushed
the
sergey/modify-default-hostports
branch
from
September 12, 2024 10:38
f9e96f7
to
e819d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated metrics configuration for CSI WekaFS Plugin to support separate ports for different components.
What changed?
How to test?
Why make this change?
This change allows for more granular control over metrics collection for different components of the CSI WekaFS Plugin. By using separate ports for each component, it becomes easier to monitor and troubleshoot specific parts of the plugin, enhancing observability and debugging capabilities.
Additional idea behind this change is avoiding port conflicts when running CSI plugin in hostNetwork mode (required for NFS)