-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-249): optimize NFS mounter to use multiple targets #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 5, 2024 07:05
94f7a10
to
23255f6
Compare
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/05/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 5, 2024 08:57
23255f6
to
5f5b338
Compare
This was referenced Sep 5, 2024
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
2 times, most recently
from
September 5, 2024 09:37
2e3f570
to
8ec4141
Compare
sergeyberezansky
changed the title
feat(CSI-247): optimize NFS mounter to use multiple targets
feat(CSI-247,CSI-249): optimize NFS mounter to use multiple targets
Sep 8, 2024
This was referenced Sep 11, 2024
Merged
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 11, 2024 10:11
58ac8ed
to
8037bc4
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 11, 2024 10:11
8ec4141
to
3ff4398
Compare
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 11, 2024 11:11
8037bc4
to
1269d0d
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 11, 2024 11:11
3ff4398
to
14cd967
Compare
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 11, 2024 11:35
1269d0d
to
5945aac
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 11, 2024 11:35
14cd967
to
a71ebde
Compare
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 11, 2024 11:51
5945aac
to
4ad8961
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 11, 2024 11:51
a71ebde
to
055b17d
Compare
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 11, 2024 13:02
4ad8961
to
ae27838
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 11, 2024 13:02
055b17d
to
117c5f4
Compare
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 11, 2024 14:25
ae27838
to
dabc35c
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 11, 2024 14:25
117c5f4
to
15d3ad8
Compare
sergeyberezansky
changed the title
feat(CSI-247,CSI-249): optimize NFS mounter to use multiple targets
feat(CSI-249): optimize NFS mounter to use multiple targets
Sep 12, 2024
Merge activity
|
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 12, 2024 12:00
dabc35c
to
4740ca8
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 12, 2024 12:00
15d3ad8
to
ae01e9c
Compare
sergeyberezansky
force-pushed
the
sergey/csi-241-nfs-sync-map-fix
branch
from
September 12, 2024 12:45
4740ca8
to
50a5d3b
Compare
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 12, 2024 12:45
ae01e9c
to
3c596c3
Compare
sergeyberezansky
changed the base branch from
sergey/csi-241-nfs-sync-map-fix
to
graphite-base/318
September 12, 2024 12:47
sergeyberezansky
force-pushed
the
sergey/simplify-nfs-mounter
branch
from
September 12, 2024 12:47
3c596c3
to
f0d1291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a new function to determine the node's IP address based on routing to a target host.
What changed?
GetNodeIpAddressByRouting
inutils.go
that determines the node's IP address by creating a UDP connection to a target host.doMount
function innfsmount.go
to use the newGetNodeIpAddressByRouting
function, falling back toGetNodeIpAddress
if it fails.GetNodeIpAddressByRouting
function inutils_test.go
.How to test?
utils_test.go
to verify the functionality ofGetNodeIpAddressByRouting
.GetNodeIpAddress
function ifGetNodeIpAddressByRouting
fails.Why make this change?
This change improves the accuracy of determining the node's IP address for NFS mounts, especially in complex network environments. By using routing information to determine the IP address, we can ensure that the correct network interface is used for NFS communications, potentially resolving issues related to multi-homed systems or specific network configurations.
feat(deps): implement InterfaceGroup.GetRandomIpAddress()
feat(deps): implement InterfaceGroup.GetRandomIpAddress()
refactor(deps): allow multimount for NFS
refactor(deps): unmount underlying FS straight after publishing volume