fix(CSI-241): fix unmountWithOptions to use map key rather than options.String()

[sergeyberezansky]

TL;DR

Updated nfsMounter to use AsMapKey() method for mount options.

What changed?

Modified the nfsMounter struct in nfsmounter.go to use the AsMapKey() method instead of String() when accessing and manipulating the mountMap. This change affects the NewMount and unmountWithOptions functions.

How to test?

1. Create a new mount using NewMount with various mount options.
2. Verify that the mount is correctly added to the mountMap using the AsMapKey() method.
3. Attempt to unmount using unmountWithOptions and ensure the correct mount is accessed and removed from the map.
4. Test with different filesystem names and mount options to ensure consistency.

Why make this change?

The AsMapKey() method likely provides a more consistent or appropriate key for the mountMap than the String() method. This change may improve the reliability of mount tracking and management, potentially avoiding issues related to inconsistent key generation or comparison.

---

[sergeyberezansky]

• chore(deps): update sidecar versions #326
• docs(CSI-254): update official docs link in Helm templates and README #323
• feat(CSI-252): implement kubelet PVC stats #322
• refactor(CSI-250): do not maintain redundant active mounts from node server after publishing volume #320
• feat(CSI-247): implement InterfaceGroup.GetRandomIpAddress() #319
• feat(CSI-249): optimize NFS mounter to use multiple targets #318
• fix(CSI-241): fix unmountWithOptions to use map key rather than options.String() #317 👈
• feat(CSI-245): allow specifying client group for NFS #316
• chore(deps): update packages to latest versions and Go to 1.22.5 #314
• chore(deps): combine chmod with ADD in Dockerfile #313
• feat(CSI-239): moveToTrash does not return error to upper layers #312
• fix(CSI-243): service accounts for CSI plugin assume ImagePullSecret and cause error messages. #311
• feat(CSI-244): match subnets if existing in client rule #315
• fix(CSI-241): conflict in metrics between node and controller #325
• feat(CSI-213): support NFS transport #299
• fix(CSI-241): disregard sync_on_close in mountmap per FS #310
• feat(CSI-253): support custom CA certificate in API secret #324
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/03/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

[sergeyberezansky]

Merge activity

• Sep 12, 6:10 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 12, 7:43 AM EDT: Graphite couldn't merge this pull request because a downstack PR feat(CSI-245): allow specifying client group for NFS #316 failed to merge.
• Sep 12, 8:43 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.