-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dot/parachain/backing): handle GetBackedCandidatesMessage
incoming overseer message
#3704
Merged
axaysagathiya
merged 153 commits into
feat/parachain
from
axay/feat/backing/handle-getbackedcandidates-message
Feb 12, 2024
Merged
feat(dot/parachain/backing): handle GetBackedCandidatesMessage
incoming overseer message
#3704
axaysagathiya
merged 153 commits into
feat/parachain
from
axay/feat/backing/handle-getbackedcandidates-message
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3281) Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com> Co-authored-by: Edward Mack <emack@pop-os.localdomain>
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
…ement/1 protocol (#3354) - Added `StatementFetchingRequest` and `StatementFetchingResponse` varying data types. - implemented 'network.Message` interface in `StatementFetchingRequest` and 'network.ResponseMessage` interface in `StatementFetchingResponse` as they will be passed into `func (rrp *RequestResponseProtocol) Do(to peer.ID, req Message, res ResponseMessage) error` function as `req` and `res`. - I didn't want to create a new YAML file here. so I decided to rename the YAML file name and variable(in which data of the YAML file getting unmarshalled) name so that I can use them in this PR.
…collation/1 protocol (#3356)
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
…available_data/1 protocol (#3368) - Added AvailableDataFetchingRequest and AvailableDataFetchingResponse types. - Implemented 'network.Message' interface in AvailableDataFetchingRequest and 'network.ResponseMessage' interface in AvailableDataFetchingResponse as they will be passed into this function as req and res.
…g statement and collation (#3374) added New() method and decode test for below varying data types. - statement - statement distribution message - collation protocol - collator protocol message
…pov/1 protocol (#3365) - Added PoVFetchingRequest and PoVFetchingResponse types. - Implemented 'network.Message' interface in PoVFetchingRequest and 'network.ResponseMessage' interface in PoVFetchingResponse as they will be passed into this function as req and res.
#3277) - Added parachain service - Registered collation and validation protocol - Confirmed that we can communicate with collators by talking to them in `run()` function
Implemented following parachain host runtime calls - ParachainHost_persisted_validation_data - ParachainHost_validation_code
This commit adds all the functions required for parachain candidate validations. With this commit, we are able to take candidate receipts and - get validation data for it, - perform basic checks on it, - run respective parachain's validate_block on parachain's runtime, - get validate results from parachain's runtime and verify those validation results again relaychain runtime, - and declare candidate as valid or invalid in the end. This commit also includes tests for candidate validation.
…3382) Co-authored-by: Kanishka <kanishkatn@gmail.com> Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com> Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
#3427) Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Use wazero runtime instance instead of wasmer runtime instance
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
axaysagathiya
added
A-blocked
issue or PR is blocked until something else changes.
S-subsystems-backing
issues related to polkadot host backing subsystem functionality.
labels
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Will approve after dependent PRs are merged!
…ge (#3600) - implements logic in the Candidate Backing Subsystem to handle canSecond message. - The subsystem checks if it's allowed to second a candidate based on specific rules: - collations must be built on the root of a fragment tree or have a parent node representing a backed candidate. - If async backing is disabled for the candidate's relay parent, the response is always false.
…s for availability store subsystem (#3640) Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
…/backing/handle-getbackedcandidates-message
3 tasks
Base automatically changed from
axay/feat/backing/handle-second-message
to
feat/parachain
February 12, 2024 07:11
axaysagathiya
removed
the
A-blocked
issue or PR is blocked until something else changes.
label
Feb 12, 2024
…e func" This reverts commit ad6d73d.
kishansagathiya
approved these changes
Feb 12, 2024
EclesioMeloJunior
approved these changes
Feb 12, 2024
axaysagathiya
deleted the
axay/feat/backing/handle-getbackedcandidates-message
branch
February 12, 2024 13:18
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
…ming overseer message (#3704) GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…ming overseer message (#3704) GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
…ming overseer message (#3704) GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…ming overseer message (#3704) GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…ming overseer message (#3704) GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
need to merge ONLY AFTER #3682 gets merged
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
closes #3504
Primary Reviewer
@kishansagathiya @EclesioMeloJunior