Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dot/parachain/backing): handle GetBackedCandidatesMessage incoming overseer message #3704

Merged

Conversation

axaysagathiya
Copy link
Contributor

@axaysagathiya axaysagathiya commented Jan 17, 2024

Note

need to merge ONLY AFTER #3682 gets merged

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

closes #3504

Primary Reviewer

@kishansagathiya @EclesioMeloJunior

kanishkatn and others added 30 commits September 14, 2023 17:38
…3281)

Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>
Co-authored-by: Edward Mack <emack@pop-os.localdomain>
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
…ement/1 protocol (#3354)

- Added `StatementFetchingRequest` and `StatementFetchingResponse`  varying data types.

- implemented 'network.Message` interface in `StatementFetchingRequest` and 'network.ResponseMessage` interface in `StatementFetchingResponse` as they will be passed into `func (rrp *RequestResponseProtocol) Do(to peer.ID, req Message, res ResponseMessage) error` function as `req` and `res`.

- I didn't want to create a new YAML file here. so I decided to rename the YAML file name and variable(in which data of the YAML file getting unmarshalled) name so that I can use them in this PR.
…chunk/1 protocol (#3362)

- Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types.

- implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
…available_data/1 protocol (#3368)

- Added AvailableDataFetchingRequest and AvailableDataFetchingResponse types.
- Implemented 'network.Message' interface in AvailableDataFetchingRequest and 'network.ResponseMessage' interface in AvailableDataFetchingResponse as they will be passed into this function as req and res.
…g statement and collation (#3374)

added New() method and decode test for below varying data types. 
- statement
- statement distribution message
- collation protocol
- collator protocol message
…pov/1 protocol (#3365)

- Added PoVFetchingRequest and PoVFetchingResponse types.
- Implemented 'network.Message' interface in PoVFetchingRequest and 'network.ResponseMessage' interface in PoVFetchingResponse as they will be passed into this function as req and res.
#3277)

- Added parachain service
- Registered collation and validation protocol
- Confirmed that we can communicate with collators by talking to them in `run()` function
Implemented following parachain host runtime calls
- ParachainHost_persisted_validation_data
- ParachainHost_validation_code
This commit adds all the functions required for parachain candidate validations.

With this commit, we are able to take candidate receipts and
- get validation data for it,
- perform basic checks on it,
- run respective parachain's validate_block on parachain's runtime,
- get validate results from parachain's runtime and verify those validation results again relaychain runtime,
- and declare candidate as valid or invalid in the end.

This commit also includes tests for candidate validation.
…3382)

Co-authored-by: Kanishka <kanishkatn@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
#3427)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Use wazero runtime instance instead of wasmer runtime instance
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
@axaysagathiya axaysagathiya marked this pull request as ready for review January 22, 2024 13:52
@axaysagathiya axaysagathiya added A-blocked issue or PR is blocked until something else changes. S-subsystems-backing issues related to polkadot host backing subsystem functionality. labels Jan 23, 2024
Copy link
Contributor

@kishansagathiya kishansagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will approve after dependent PRs are merged!

dot/parachain/backing/statement_table.go Show resolved Hide resolved
axaysagathiya and others added 8 commits January 23, 2024 19:24
…ge (#3600)

- implements logic in the Candidate Backing Subsystem to handle canSecond message. 
- The subsystem checks if it's allowed to second a candidate based on specific rules: 
    - collations must be built on the root of a fragment tree or have a parent node representing a backed candidate. 
    - If async backing is disabled for the candidate's relay parent, the response is always false.
…s for availability store subsystem (#3640)

Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Base automatically changed from axay/feat/backing/handle-second-message to feat/parachain February 12, 2024 07:11
@axaysagathiya axaysagathiya removed the A-blocked issue or PR is blocked until something else changes. label Feb 12, 2024
@axaysagathiya axaysagathiya merged commit e76a6f8 into feat/parachain Feb 12, 2024
22 checks passed
@axaysagathiya axaysagathiya deleted the axay/feat/backing/handle-getbackedcandidates-message branch February 12, 2024 13:18
timwu20 pushed a commit that referenced this pull request Jun 15, 2024
…ming overseer message (#3704)

GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
…ming overseer message (#3704)

GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
…ming overseer message (#3704)

GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
…ming overseer message (#3704)

GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
…ming overseer message (#3704)

GetBackedCandidatesMessage is a message from an overseer requesting a set of backable candidates that could be backed in a child of the given relay parent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-subsystems-backing issues related to polkadot host backing subsystem functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants