Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controls] Remove "Set all sizes to default" check box #21

Closed

Conversation

Heenawter
Copy link

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

alisonelizabeth and others added 30 commits April 21, 2022 14:30
* Revert "Revert "[Console] Add Kibana APIs Support (elastic#128562)""

This reverts commit f41dc1f.

* fix functional test
…astic#129977)

* feat: move autocomplete logic from data plugin to unified search

* minor fix after comments

* updated Documentation: data.autocomplete -> unifiedSearch.autocomplete

* changed renameFromRoot order for autocomplete

* removed extra renameFromRoot in config deprecations, updated test

* added configPath for unified search plugin

* Update kibana.json

* updated path to autocomplete

* fix conflict

* fix conflict

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix Linting

* fix functional_with_es_ssl test
…ver/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields (elastic#129847)

* [test-failed]: Chrome UI Functional Tests1.test/functional/apps/discover/_filter_editor·ts - discover app discover filter editor filter editor version fields should support range filter on version fields

* Set "version_test" permissions to kibana_admin role

* Add after block to reset permission

* Add "test_logstash_reader" role

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Change ContextContainer to lazily initialize providers

* Introduce CustomRequestHandlerContext, start adapting usages

* adapt IContextProvider's return type

* start fixing violations

* fixing violations - 2

* adapt home routes

* fix remaining core violation

* fix violations on core tests

* fixing more violations

* fixing more violations

* update generated doc...

* fix more violations

* adapt remaining RequestHandlerContext

* fix more violations

* fix non-async method

* more fixes

* fix another await in non async method

* add yet another missing async

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* add yet yet another missing async

* update fleet's endpoints

* fix telemetry endpoints

* fix event_log endpoints

* fix some security unit tests

* adapt canvas routes

* adapt alerting routes

* adapt more so_tagging routes

* fix data_enhanced routes

* fix license_management routes

* fix file_upload routes

* fix index_management routes

* fix lists routes

* fix snapshot_restore routes

* fix rule_registry routes

* fix ingest_pipelines routes

* fix remote_clusters routes

* fix index_lifecycle_management routes

* improve and fix the lazy implementation

* fix triggers_actions_ui endpoints

* start fixing unit tests

* fix cases routes

* fix transform routes

* fix upgrade_assistant routes

* fix uptime route wrapper

* fix uptime route wrapper bis

* update osquery routes

* update cross_cluster_replication routes

* fix some ML routes / wrappers

* adapt maps routes

* adapt rollup routes

* fix some canvas unit tests

* fix more canvas unit tests

* fix observability wrapper

* fix (?) infra type hell

* start fixing monitoring

* fix a few test plugins

* woups

* fix yet more violations

* fixing UA  tests

* fix logstash handlers

* fix fleet unit tests

* lint?

* one more batch

* update security_solution endpoints

* start fixing security_solution mocks

* start fixing security_solution tests

* fix more security_solution tests

* fix more security_solution tests

* just one more

* fix last (?) security_solution tests

* fix timelion javascript file

* fix more test plugins

* fix transforms context type

* fix ml context type

* fix context tests

* fix securitySolution withEndpointAuthz tests

* fix features unit tests

* fix actions unit tests

* fix imports

* fix duplicate import

* fix some merge problems

* fix new usage

* fix new test

* introduces context.resolve

* down the rabbit hole again

* start fixing test type failures

* more test type failures fixes

* move import comment back to correct place

* more test type failures fixes, bis

* use context.resolve for security solution rules routes

* fix new violations due to master merge

* remove comment

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* init pie chart

* styling

* donut card

* styling

* parser

* wording

* unit tests

* disable detectionResponse feature flag

* rename props

* add detection_response folder

* add query hook

* disable detectionResponse

* alerts button and count

* toggle query

* fix unit tests

* disable dashboard

* fillColor

* disable dashboard

* fix legends

* detectionResponseEnabled

* review

* rm old tests

* review

* fix types

* legend

* rename

* rm i18n keys

* unit tests

* update i18n keys

* add unit tests

* fix unit tests

* review

* review

* styling

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* styling

* styling

* useEuiTheme

* useEuiTheme

* enable feature flag

* disable flag

* enable dashboard

* disable dashboard

* Update x-pack/plugins/security_solution/public/common/components/charts/donutchart.tsx

Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>

* styling

* styling

* unit tests

* unit tests

* unit test

* unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…c#130599)

* Tests.test/functional/apps/visualize/_tsvb_time_series·ts - visualize app visualize

* Update _tsvb_time_series.ts
We forcefully upgrade the trim sub-dependency to v1.0.1 because of an
old known security vulnerability. Two of our dependencies who previously
depended on trim no longer does so, and we can therefore now upgrade
those to get rid of the warnings generated because of this forceful
upgrade.
…ge key for overview and ale… (elastic#130538)

* save alerts config in different localStorage key for overview and alerts page

* remove ALERT_TABLE_STATE_STORAGE_KEY
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* update keys

* update

* update test keys

* change keys

* more keys

* updates

* update

* update

* udate

* update test

* update
…flag (elastic#128913)

* Remove references to ruleRegistryEnabled feature flag

* Fix remaining tests using describe.each

* Test fixes

* alert -> rule

* Fix import rule tests

* Fix output_index in tests

* Tryin' again

* Another test fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* new file used by Kibana QA team to pull PRs for testing

* moved file

* updated with more labels to exclude

* added readme

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…de from timelines plugin (elastic#130928)

## [Security Solution] [Investigations] [Tech Debt] removes redundant code from the timelines plugin

This follow-up PR removes redundant code from the `timelines` plugin, identified while implementing elastic#130740
…tic#128319)

* connectorTypeOverrides key in kibana.yml can create a connector type specific action config.

* Update docs and docker allowed keys
…elastic#130541)

This PR fixes a UI glitch where preconfigured connectors couldn't show a deprecation warning on SN connectors as the check on the client side couldn't support them.
* ux app, remove deprecated api usage

* update
kertal and others added 27 commits May 4, 2022 11:30
… copy (elastic#130561)

* Add missing period at the end of the sentence

* Copy update due old pr comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [APM] Update template title for service groups

* [APM] Update link titles in global search

* Fix translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…1493)

* Export cases metrics

* Fixes

* Add integration tests

* Add comment

* Add signal
* skipping flaky test

* Fix environment suggestion test

* removing comment

Co-authored-by: Kate Patticha <aikaterini.patticha@elastic.co>
…lastic#122203)

* Added ellipsis truncation to apm dependency

* Added ellipsis truncation to apm service

* Removed un-used variable

* Added ellipsis truncation

* removing unused import

* modified css classname

* created a new component for truncation without tooltip

* using text truncate styling and removed truncatewithouttooltip component

* restored styledlink
* adding missing color to use eui theme hook

* button and spacing refactor

* updating colors and spacing on alerts

* adding custom components for nbsp and split text

* updating test to match nbsp instead of white space

* update process tree node to match design spec
* fix bug

* fix unit test

* bing back tests alive after a long CPR

* fix test and bring back recursive aggs

* I need to do an intersectiona and not union

* fix last integration test
…to account for more edge cases (elastic#130511)

## Summary

Updates the legacy actions migration code to account for edge cases we had not initially caught. Thanks to testing from some teammates, they reported seeing the following behavior:

- Rules created pre 7.16 with no actions still create the legacy action sidecar (but not a `siem.notifications` legacy actions alert) which upon migration to 7.16+ was not being deleted
- Rules created pre 7.16 with actions that run on every rule run create the legacy action sidecar(but not a `siem.notifications` legacy actions alert) which upon migration to 7.16+ was not being deleted
- Rules created pre 7.16 with actions that were never enabled until 8.x did not have a `siem.notifications` legacy actions alert type created

Because the legacy migration code relied on checking if a corresponding `siem.notifications` SO existed to kick off the necessary cleanup/migration, the above edge cases  were not being caught.
@Heenawter Heenawter closed this May 6, 2022
@Heenawter Heenawter deleted the 2022-05-06_remove-set-all-sizes-checkbox_v2 branch May 6, 2022 21:56
@Heenawter Heenawter restored the 2022-05-06_remove-set-all-sizes-checkbox_v2 branch May 6, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.